microsoft / microsoft/monaco-editor

[Bug] Since 0.46.0, dropped text append "$0"

Open
#4,386 14 comments 4 reactions 1 assignee View on GitHub

@mjbvz is already working on this.

Since Feb 20, 2024.

bug help wanted
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.46.0#example-creating-the-editor-hello-world

Monaco Editor Playground Code

Empty.

Reproduction Steps
  1. Open a notepad
  2. Type "text" in the notepad
  3. Drag and drop the text from the notepad to the editor on the playground
Actual (Problematic) Behavior

The editor contains "text$0".

Expected Behavior

The editor should contain "text".

Additional Context

I'm not sure, but I guess the problem must have appeared with this PR: https://github.com/microsoft/vscode/pull/202049
and come from this code: https://github.com/microsoft/vscode/blob/7f07489455fda8bc1841b98b9b7e58b20b7ee3ef/src/vs/editor/contrib/dropOrPasteInto/browser/edit.ts#L34

cc. @mjbvz

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.