microsoft / microsoft/monaco-editor
[Bug] Platform is not always well detected
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
No response
Monaco Editor Playground Code
No response
Reproduction Steps
No response
Actual (Problematic) Behavior
No response
Expected Behavior
No response
Additional Context
Since https://github.com/microsoft/vscode/pull/200935, process existing takes priority over navigator to detect is it run inside a browser. The issue is that with some bundlers like webpack, it is sometimes required to polyfill node internal (like process).
It now has as consequence to wrongly be detected as a native platform which can have consequences, for instance:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the platform-detection change referenced in the issue and its effects in src/vs/editor/browser/viewParts/lines/viewLine.ts and src/vs/editor/contrib/clipboard/browser/clipboard.ts. Reproduce the behavior with a bundler-provided process polyfill, then verify that browser environments are detected correctly without regressing native platform detection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, webpack
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100