microsoft / microsoft/monaco-editor

[Bug] Go to Definition context menu item displays an incorrect hotkey (it shows Ctrl+F12, but is actually F12)

Open
#4,252 2 comments 0 reactions 1 assignee View on GitHub

@ulugbekna is already working on this.

Since Dec 14, 2023.

Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

Link

Monaco Editor Playground Code
monaco.languages.register({ id: 'foo' });

monaco.languages.registerDefinitionProvider('foo', {
	provideDefinition(model, position, token) {
		return [];
	}
});

const editor = monaco.editor.create(document.getElementById("container"), {
	value: 'test',
	language: 'foo',
	automaticLayout: true,
});
Reproduction Steps
  1. Paste the code from Monaco Editor Playground Code into the monaco editor playground.
  2. In the Preview pane, right-click to open the context menu.
  3. --> The Go to Definition menu item shows that Ctrl+F12 is the hotkey for Go to Definition, but it is actually just F12.
Actual (Problematic) Behavior

Context menu displays the wrong hotkey (Ctrl+F12) for Go to Definition.

Expected Behavior

Context menu should display F12 for Go to Definition.

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.