microsoft / microsoft/monaco-editor

[Bug] Make insertText, insertTextRules, label available for tsMode suggestions

Open
#4,228 0 comments 0 reactions 1 assignee View on GitHub

@mjbvz is already working on this.

Since Dec 13, 2023.

feature-request
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Context
  • This issue is not a bug report. (please use a different template for reporting a bug)
  • This issue is not a duplicate of an existing issue. (please use the search to find existing issues)
Description

SuggestAdapter's provideCompletionItems method of tsMode does not support

  1. insertText
  2. insertTextRules
  3. label

From the entry object

The code assigns name to both insertText and label. My usecase for typescript requires to rename the label while the insertion text is different. I have extended the tsWorker file to modify the insertText but it does not work here as its omitted

https://github.com/microsoft/monaco-editor/blob/main/src/language/typescript/languageFeatures.ts#L487

Screenshot 2023-10-27 at 8 10 12 PM
Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.