microsoft / microsoft/monaco-editor
[Bug] Many duplicates in minified tsWorker.js leading to large file
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Reproduction Steps
- Open a compiled version of the file min/vs/language/typescript/tsWorker.min.js CDN Example
- Optionally copy the code in a VS Code window
- Search for
interface CanvasDrawPath { - Note that the definition is found twice
- This duplication issue is the case for a lot of code
Actual (Problematic) Behavior
The minified version of tsWorker.js is around 4.6 MB I want to use the Monaco editor in a web extension, but this allows a maximum file size of 4 MB
If the code duplication is fixed, that would reduce the filesize enough to get below 4 MB
Expected Behavior
No duplicate code generated during the build
Additional Context
Related Add_ons Linter issue https://github.com/mozilla/addons-linter/issues/3915
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the generated min/vs/language/typescript/tsWorker.min.js file and the reported duplicate interface CanvasDrawPath definition, using the CDN example to reproduce the size and duplication. Trace the build inputs that produce tsWorker.js and verify that the duplicate code is removed without changing the worker output; done means the minified file is below the reported 4 MB limit and no longer contains the duplicated definition.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100