microsoft / microsoft/monaco-editor

[Bug] Menu inside inline completions action bar is not styled correctly

Open
#3,984 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted inline-completions
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.38.0#XQAAAAL-AQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw0VqKkeHknAbDPEwV3WH5GCr7ZoFvR8KyFLMQqKbNQzGGAx-eFJTwGiTxdnT_ukndQWeN8vWOBsX-mtPCMwf33id5yWS_Hd-yCR8vTf051-SBQLD2UYC7zo7URq3nZpNcK8-oT8UYeFOA_B7KxF57WyBvYkqgBhPipaFZTOL4bnQR2CXH3z4rjfy7s3p2ITt2Mms6CduoTwBY4d8ElP5z0N3uHJkVa5g3Fh-y0gfSvACFJJzemUj4Evl86SL9BZk57FRiTgQqOUqvjFao9nWQZupfFH2gS77i1fVXyy5GlSZBVilxRv4p81HMD_OBy4LwibZklco8AT-CmMQKYtadpwiFqWTTEFRqfepMg-k2YXvZShER_vbGBQ

Monaco Editor Playground Code
monaco.editor.create(document.getElementById('container'), {
  value: "function hello() {\n\talert('Hello world!');\n}",
  language: 'javascript',
  inlineSuggest: {
      enabled: true,
  }
});
 
class InlineCompleter {
provideInlineCompletions() {
      return {items: [{insertText: '11111'}, {insertText: '22222'}]};
  }
  freeInlineCompletions() {}
}
monaco.languages.registerInlineCompletionsProvider('javascript', new InlineCompleter());
Reproduction Steps
  1. Trigger the inline completions provider
  2. Hover over suggested text so that action bar shows up
  3. Click three-dot menu in action bar
  4. Notice there are no styles applied to the three-dot menu (bug)
Actual (Problematic) Behavior

The three-dot menu does not have any styling applied to it. It looks like it is added to the DOM outside of the .monaco-editor context and therefore thinks that none of the styling variables exist. The result is that the menu is unstyled.

Expected Behavior

The three-dot menu for inline completions action bar should have styling applied to it.

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the linked Monaco Editor Playground and reproduce the unstyled three-dot menu in the inline completions action bar. Trace how that menu is styled relative to the .monaco-editor context; done means the menu has the expected styling in the supplied reproduction.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.