microsoft / microsoft/monaco-editor

[Bug] CSS Property value not highlighted when colon followed with newline

Open
#3,079 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug css help wanted languages-basic
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Code
// The Monaco Editor can be easily created, given an
// empty container and an options literal.
// Two members of the literal are "value" and "language".
// The editor takes the full size of its container.

monaco.editor.create(document.getElementById('container'), {
	value: `<style>#abc {
grid-template-areas:
"abc"
"hi";
}</style>`,
	language: 'html'
});
Actual Behavior

Notice how the stings aren't highlighted.

Expected Behavior

The strings should be highlighted.

Additional Context

This is valid CSS and is used in CSS Grid: https://www.freecodecamp.org/learn/responsive-web-design/css-grid/place-items-in-grid-areas-using-the-grid-area-property. This problem occurs only when the colon is immediately followed by a newline.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the supplied Monaco Editor Playground code and inspect the tokenization of the CSS inside the HTML style block. Trace the HTML/CSS syntax-highlighting entry points to reproduce the newline-after-colon case. Done means the strings in the CSS Grid value are highlighted correctly without regressing other CSS values.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, html, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.