microsoft / microsoft/monaco-editor

Include Portuguese (Brazil) NLS language in distribution

Open
#2,420 2 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

It seems the Portuguese (Brazil) language does exist for VSCode, and thus Monaco, as an external language pack.

But it is not bundled with Monaco by default.

In the vscode build script, I see the following code:

// languages requested by the community to non-stable builds
exports.extraLanguages = [
    { id: 'pt-br', folderName: 'ptb' },
    { id: 'hu', folderName: 'hun' },
    { id: 'tr', folderName: 'trk' }
];

Is pt-br really "unstable"? Based on its maintenance in vscode-loc, number of downloads etc it seems worthy of being included in monaco by default. Thoughts?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced VS Code build/lib/i18n.js file and inspect how Monaco's distribution selects bundled language packs. Determine where the extraLanguages setting is consumed, then verify that pt-br is included in the default Monaco distribution.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, vscode
Domain
internationalization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.