[Monarch Julia grammar] interpolation breaks inside multiline strings

Open
#2,357 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
julia
Domain
tooling

Research direction

Start with the editable copy of the current Julia mode in the linked CodeSandbox and compare its multiline interpolation cases with the reported behavior. Use the sandbox test cases to verify that encountering an inner right parenthesis no longer breaks syntax highlighting, including the final interpolation-closing parenthesis.

Written by the indexing model from the issue text.

Description

bug grammars help wanted

monaco-editor version: 0.22.3
Browser: Google Chrome 88.0.4324.182 (Official Build) (64-bit) (cohort: 88_Win_182)
OS: Windows 10

Hi!

Using the built-in julia mode, string interpolation inside a multiline string seems to break the syntax highlighting whenever any right parenthesis ) is encountered, not just the final one that closes the interpolation. Example:

Multiline_interpolation_breaks_in_monaco

I had a little go at it but I have to learn more about Monarch before I can be of any use here. Here's a codesandbox with some more test cases, and an editable copy of the current julia mode included with monaco-editor for easy experimenting.

Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/monaco-editor

All issues in microsoft/monaco-editor

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.