getVisibleRanges: allow for partial visibility
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start with the Editor#getVisibleRanges API and trace how it determines vertical visibility. Review the existing behavior and consider the reported backward-compatibility concern before deciding whether partial visibility should be supported through an additional argument; done means the API handles the requested scroll-synchronization case without breaking current behavior.
Written by the indexing model from the issue text.
Description
Currently Editor#getVisibleRanges includes only lines that are fully visible, at least vertically.
I think that may be a mistake because when implementing scroll synchronization this creates discontinuities between lines, e.g. you synchronize the top of line 1, which is let's say 20px tall, which is at the very top of the editor, now if you scroll just one pixel down that line is considered not visible, even though most of it is actually visible still, and crucially the next visible line will be ~19px below, causing a jump in the synchronization. If instead partially visible lines are considered visible that would smooth out all the discontinuities.
Maybe this can't be changed for backwards compatibility, but at least an extra argument for controlling this behavior would be pretty useful.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/monaco-editor
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
microsoft/monaco-editor#5314 · 2 comments · 4 reactions ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
microsoft/monaco-editor#5248 · 8 comments · 57 reactions ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
microsoft/monaco-editor#5193 ·
-
[Bug] colorizeElement method doesn't color the whole text if domNode has more than one #text child Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoft/monaco-editor#4571 ·
-
bug help wanted integration
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
microsoft/monaco-editor#4045 · 8 comments · 11 reactions ·
All issues in microsoft/monaco-editor
Similar issues
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100