microsoft / microsoft/monaco-editor

Add possibility to remove keybindings

Open
#2,157 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

editor-api feature-request
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

monaco-editor version: 0.21.1
Browser: Chrome latest
OS: Mac OS latest

The issue is when connecting to language server using monaco-languageclient, it throws error. (https://github.com/TypeFox/monaco-languageclient/issues/231)

and did a bit research, it seems with new version, the monaco-editor removed dynamicCommand interface from _commandService. any insights to fix ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the error with monaco-languageclient and Monaco Editor 0.21.1, then inspect _commandService and the removed dynamicCommand interface. Done means keybindings can be removed without the reported language-server error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.