microsoft / microsoft/monaco-editor

Monarch embedded @pop rule requires two carets

Open
#1,127 2 comments 0 reactions 1 assignee View on GitHub

@alexdima is already working on this.

Since Dec 13, 2019.

bug
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

version: 0.14.3

If an embedded mode @pop rule requires to match only at the beginning of a line, one must insert two ^^ carets instead of one for it to take effect.

This is probably caused by _findLeavingNestedModeOffset ignoring matchOnlyAtLineStart when it rebuilds its regex.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.