microsoft / microsoft/mimalloc
Incorrect masks used in mi_bitmap_is_claimedx_across
- Dominant language
- C
- Stars
- 13.4k
- Forks
- 1.2k
- Avg merge
- 4d 45m
- Merged PRs (30d)
- 13
Description
In `mi_bitmap_is_claimedx_across`, the middle fields and the post field all compare the field contents against `pre_mask`. Compared to the preceding functions, it looks like these should be using `mid_mask` and `post_mask`, respectively.
I can’t say if this has caused any issues; I've just been reading the code to understand how the atomic operations work.
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate mi_bitmap_is_claimedx_across and compare its mask checks with the preceding bitmap functions. Verify that middle fields are compared with mid_mask and the post field with post_mask; done means the correction is validated by the repository's relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 64/100