microsoft / microsoft/mimalloc

Linking mimalloc-test-stress-dynamic fails on OpenBSD

Open
#1,127 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
13.4k
Forks
1.2k
Avg merge
4d 45m
Merged PRs (30d)
13

Description

Commit 07743454e5a04356144918e32b1e2ce8e80c1726 breaks `mimalloc-test-stress-dynamic` linking:

```
[100%] Linking C executable mimalloc-test-stress-dynamic
ld: warning: test-stress.c(CMakeFiles/mimalloc-test-stress-dynamic.dir/test/test-stress.c.o:(main)): warning: rand() may return deterministic values, is that what you want?
ld: error: undefined symbol: pthread_create
>>> referenced by test-stress.c
>>> CMakeFiles/mimalloc-test-stress-dynamic.dir/test/test-stress.c.o:(main)

ld: error: undefined symbol: pthread_join
>>> referenced by test-stress.c
>>> CMakeFiles/mimalloc-test-stress-dynamic.dir/test/test-stress.c.o:(main)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error 1 in . (CMakeFiles/mimalloc-test-stress-dynamic.dir/build.make:101 'mimalloc-test-stress-dynamic': /usr/local/bin/cmake -E cmake_l...)
*** Error 2 in . (CMakeFiles/Makefile2:332 'CMakeFiles/mimalloc-test-stress-dynamic.dir/all': make -s -f CMakeFiles/mimalloc-test-stress-dyn...)
*** Error 2 in /home/test/mimalloc/out/release (Makefile:146 'all': make -s -f CMakeFiles/Makefile2 all)
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/test-stress.c and the CMake build configuration introduced or changed by commit 07743454e5a04356144918e32b1e2ce8e80c1726. Reproduce the dynamic stress-test build on OpenBSD and inspect the link command for the missing pthread symbols. Done means mimalloc-test-stress-dynamic links successfully on OpenBSD without breaking other builds.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cmake
Domain
build-system, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.