microsoft / microsoft/mimalloc

Question about the return value of method `mi_page_extend_free(...)`

Open
#1,120 2 comments 0 reactions 0 assignees View on GitHub
stale
Dominant language
C
Stars
13.4k
Forks
1.2k
Avg merge
4d 45m
Merged PRs (30d)
13

Description

Does the following code should return `false` instead of `true`?

https://github.com/microsoft/mimalloc/blob/09a27098aa6e9286518bd9c74e6ffa7199c3f04e/src/page.c#L642

Which should signal the page extend failed?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/page.c at the linked line and inspect the callers of mi_page_extend_free(...) to understand how its return value is interpreted. Trace the success and failure paths, then verify that the returned boolean matches the documented or caller-expected outcome and run the relevant allocator tests, if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.