microsoft / microsoft/mimalloc
Add compile time option to disable reading from environment
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.4k
- Forks
- 1.2k
- Avg merge
- 4d 45m
- Merged PRs (30d)
- 13
Description
Reading configuration from environment can be undesired in some circumstances and made debugging problematic due to different configurations on different machines.
Additionally, doing so isn't really a normal practice for libraries so it can be unexpected for a user.
As such, I'd like to request a CMake flag that'd remove the code for that from the build to be added.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the CMake options and the code paths that read configuration from the environment. Trace how those paths are included in the build, then add a compile-time option that excludes them when disabled. Done means the option is documented by its behavior and both enabled and disabled builds work as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cmake
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100