microsoft / microsoft/microsoft-ui-xaml

Regression: ContentDialog without animation when XamlChangeId.OptimizeApplyStyles enabled

Open
#11,257 3 comments 0 reactions 1 assignee Claimed by @codendone View on GitHub
area-Dialogs area-Styling bug Regression team-Core
Dominant language
C++
Stars
8.4k
Forks
942
Avg merge
2d 7h
Merged PRs (30d)
105

Description

### Describe the bug

When `XamlChangeId.OptimizeApplyStyles` is applied, the entrance animation of a `ContentDialog` no longer plays. To be exact, when you create a `CustomContentDialog` that derives from `ContentDialog`.

When removing the XamlChangeId opt-in, the entrance animation plays again.

### Why is this important?

A user-facing regression following the performance optimization, disturbing the user experience.

### Steps to reproduce the bug

[ContentDialogAnimationRepro.zip](https://github.com/user-attachments/files/30180422/ContentDialogAnimationRepro.zip)

Run attached repro app and click the button to open the custom ContentDialog. See that the animation is missing.
Then remove the `OptimizeApplyStyles` from the project file to see that the animation returns.

### Actual behavior

_No response_

### Expected behavior

_No response_

### Screenshots

_No response_

### NuGet package version

2.3.1

### Windows version

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.