microsoft / microsoft/microsoft-ui-xaml

Odd visual state name discrepancy for `TabViewItem`

Open
#10,748 0 comments 0 reactions 0 assignees View on GitHub
area-TabView needs-triage
Dominant language
C++
Stars
8.4k
Forks
942
Avg merge
2d 7h
Merged PRs (30d)
105

Description

While porting the `TabViewItem` code to Uno Platform I noticed a suspicious discrepancy between state name and constant name:

https://github.com/microsoft/microsoft-ui-xaml/blob/adae19431771d29b4c94d7a2bfd889e7d8c0fa4c/src/controls/dev/TabView/TabViewItem.h#L130-L131

Is this intentional, or were the state names swapped accidentally?

Contributor guide

Open the contributing guide

Research direction

Inspect src/controls/dev/TabView/TabViewItem.h at lines 130-131 and compare the visual state names with their constants. Determine whether the discrepancy is intentional or an accidental swap, then document the finding and any required correction.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.