microsoft / microsoft/microsoft-ui-xaml

Release source JSON files for AnimatedVisuals ("VisualSource") classes

Open
#10,652 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-UIDesign team-Design
Dominant language
C++
Stars
8.4k
Forks
942
Avg merge
2d 7h
Merged PRs (30d)
105

Description

The C++ files in the tree are generated by a tool; for example:

https://github.com/microsoft/microsoft-ui-xaml/blob/fb7a83b668baa612b5cc594678746dd8c1f8d8bd/src/controls/dev/AnimatedIcon/AnimatedVisuals/AnimatedAcceptVisualSource.cpp#L2-L19

While the lottie tool is open source, the JSON files do not appear to be public anywhere; please make these available as well.

```
PS C:\Users\fred\code\microsoft-ui-xaml> wsl find . -iname '*.json'
./.vs/Microsoft.UI.Xaml-Product/v17/DocumentLayout.json
./src/dxaml/cspell.json
./src/dxaml/xcp/components/imaging/lib/cgmanifest.json
./src/external/inc/gsl/cgmanifest.json
./src/external/inc/SafeInt/cgmanifest.json
./src/global.json
./src/src/XamlCompiler/BuildTasks/Antlr4.Runtime/cgmanifest.json
./src/src/XamlCompiler/BuildTasks/BindingPath/cgmanifest.json
./src/src/XamlCompiler/BuildTasks/ConditionalNamespace/cgmanifest.json
./src/src/XamlCompiler/BuildTasks/System.Xaml/cgmanifest.json
./src/src/XamlCompiler/global.json
```

No sign of the `AnimatedAcceptVisualSource.json` that the comment refers to

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/controls/dev/AnimatedIcon/AnimatedVisuals/AnimatedAcceptVisualSource.cpp and inspect the generated-file comment and surrounding AnimatedVisuals files. Trace how the lottie tool's source inputs are handled, then determine where the corresponding AnimatedAcceptVisualSource.json and other VisualSource JSON files should be released. Done means the source JSON files are publicly available with the generated C++ files.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.