microsoft / microsoft/microsoft-performance-toolkit-sdk
Remove SetLogger and SetApplicationEnvironment methods from ProcessingSource
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 239
- Forks
- 78
- Avg merge
- 4d 3h
- Merged PRs (30d)
- 2
Description
Instead, these parameters should be set via constructor dependency injection.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ProcessingSource and inspect how SetLogger and SetApplicationEnvironment are currently used. Move those dependencies to the constructor, remove the setter methods, and verify that existing callers still provide the required values and build successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- performance, tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100