microsoft / microsoft/microsoft-performance-toolkit-sdk

Force processing sources to implement data source grouping

Open
#396 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
239
Forks
78
Avg merge
4d 3h
Merged PRs (30d)
2

Description

There are two changes required:

  1. Force every processing source to implement IDataSourceGrouper. In the spirit of #395, this interface should just be removed and the method should just be added directly to the processing source class.
  2. Remove all APIs that allow passing individual data sources to process. Only keep the methods that pass groups in for processing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the processing source classes, IDataSourceGrouper, and APIs that accept individual data sources. Review the related changes in issue #395, then identify every processing entry point that must accept groups instead. Done means processing sources expose grouping directly and individual-data-source processing APIs have been removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.