microsoft / microsoft/microsoft-performance-toolkit-sdk
Support specifying data source groups when using the Engine
@mslukebo is already working on this.
Since Oct 3, 2022.
- Dominant language
- C#
- Stars
- 239
- Forks
- 78
- Avg merge
- 4d 3h
- Merged PRs (30d)
- 2
Description
Is your feature request an entirely new concept?
Yes,
Is your feature request related to an existing component?
It is related to feature request #213
Is your feature request related to a problem? Please describe.
With the proposed changes in #213, engine users have no way to specify which groups returned by an IDataSourceGrouper get used during processing.
Describe the solution you'd like
A new interface IDataSourceGroupResolver is created for picking out the IDataSourceGroups to use for processing. It would look like
public interface IDataSourceGroupResolver
{
IReadOnlyCollection<IDataSourceGroup> Resolve(Guid processingSourceGuid, IReadOnlyCollection<IDataSourceGroup> allValidGroups);
}
Then, EngineCreateInfo would have a new instance method WithResolver(IDataSourceGroupResolver resolver) that sets the IDataSourceGroupResolver to use when the engine decides which groups to actually use for processing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.