microsoft / microsoft/microsoft-performance-toolkit-sdk

Should CreateLogger() be added to IApplicationEnvironment?

Open
#203 0 comments 0 reactions 1 assignee View on GitHub

@mslukebo is already working on this.

Since Jun 7, 2022.

enhancement untriaged
Dominant language
C#
Stars
239
Forks
78
Avg merge
4d 3h
Merged PRs (30d)
2

Description

This functionality currently exists in IProcessorEnvironment, but not IApplicationEnvironment. This is limiting because some global services might need to be able to create a logger outside of a specific processor instance (e.g. a symbol service).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.