microsoft / microsoft/mcp

Link validation doesn't catch GH link changes in the current PR

Open
#982 1 comment 1 reaction 2 assignees Assigned to @chidozieononiwu View on GitHub
Central-EngSys engineering item server-Azure.Mcp
Dominant language
C#
Stars
3.7k
Forks
624
Avg merge
2d 20h
Merged PRs (30d)
220

Description

Readmes are checked for broken links using Verify-Links.ps1. That script checks that the URLs in a markdown or html file are valid and don't return an error result, e.g. 404.

The current script doesn't detect that a PR will be deleting a file that a url targets. It also doesn't detect that a change creates a file that a url targets when the github org isn't `Azure`.

We should improve the script so that:
- validation fails if the current PR deletes a file that a url references (when the url targets main, etc)
- validation succeeds if the current PR creates a file that a url references (even when the github org != 'azure')

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.