Standardize dependency injected constructor parameter validation
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.7k
- Forks
- 624
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 220
Description
While migrating `IBaseCommand` implementations to use dependency injection for all services they require it was noted that there is inconsistent handling for those parameters. In some cases they're used as-is and in other cases they're validated for being non-null. This issue is a follow-up to make that handling consistent across all implementation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for IBaseCommand and all of its implementations, then compare how dependency-injected constructor parameters are handled. Establish the consistent non-null validation pattern from the existing implementations and apply it across the remaining implementations; done means the handling is consistent throughout.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100