microsoft / microsoft/mattersim

Dependency management

Open
#165 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
598
Forks
97
PR merge metrics
No merged PRs in 30d

Description

Contact Details

No response

Bug Description

Hi all,
could you differentiate those packages in pyproject.toml that are really required to run the forcefield and those that your package should not have any conflicts with and use the latter to run your automatic tests?

Currently, we cannot re-integrate mattersim easily in atomate2 as it depends on phono3py. I am quite sure that is not used to run the forcefields but rather required for one of your projects.

Thanks in advance!

MatterSim Version

current

Python Version

3.12

Reproduction Steps
Expected Behavior

That i can install it without phono3py.

Actual Behavior

i have to install phono3py

Error Logs

Code of Conduct
  • I agree to follow the project's Code of Conduct

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pyproject.toml and separate dependencies required to run the forcefield from packages needed only for project-specific work or automated tests. Verify that a clean installation of MatterSim no longer requires phono3py, while the automated tests still install and use their needed dependencies.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.