microsoft / microsoft/markitdown
`convert_hn` isn't being used properly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 186k
- Forks
- 13.7k
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 49
Description
it seems you intended to override the convert_hn function in markdownify but that function is actually called _convert_hn (see the source).
So I think that function never actually gets called. And if it were called it would not work properly as it would call a non-existent function.
Changing it to _convert_hn fixes it though I'm not actually sure this patch is needed at all.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading markdownify/init.py around the referenced line and locating how the heading conversion method is dispatched. Then find markitdown’s corresponding override and confirm whether it is necessary; done means the intended conversion path is called without referencing a nonexistent function.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- markdown, python
- Domain
- content, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100