microsoft / microsoft/markitdown
Timeout needed
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 186k
- Forks
- 13.7k
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 49
Description
The convert_uri() method in MarkItDown makes a requests.get() call with stream=True but no timeout. This means a request to a slow or malicious server can hang indefinitely, blocking the process.
I already have a fix :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the convert_uri() method in MarkItDown and inspect its requests.get() call with stream=True; no file or test path is named. The referenced pull request #1999 contains the existing fix, so compare it with the issue to verify that slow requests no longer hang indefinitely.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100