microsoft / microsoft/maker.js
Arcs that are degenerate cause a crash on import fromSVGPathData
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 302
- Avg merge
- 21h 28m
- Merged PRs (30d)
- 5
Description
This happens with e.g. M 10 10 A 5 5 0 0 0 10 10 because it fails to find any intersection points between the two degenerate circles centered on the end points.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at fromSVGPathData and reproduce the crash with M 10 10 A 5 5 0 0 0 10 10. Trace the degenerate-circle intersection handling, then verify that importing this path completes without crashing and add or run the relevant regression test if one is available there.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100