microsoft / microsoft/maker.js

Module placement not showing correct angle

Open
#561 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2k
Forks
302
Avg merge
21h 28m
Merged PRs (30d)
5

Description

I am trying to draw model on chains using layout.childrenOnChain but some of modules are not placed correctly.
Any idea on this?

image

Code reproduced here
https://codesandbox.io/s/makerjs-module-placement-angle-are-incorrect-mrrrwv

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the linked CodeSandbox reproduction and inspect the layout.childrenOnChain entry point used to place the modules. Compare the resulting module angles and positions with the intended chain layout shown in the reproduction; done means the affected modules are placed at the correct angles and positions.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.