microsoft / microsoft/maker.js

Playground export units

Open
#487 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2k
Forks
302
Avg merge
21h 28m
Merged PRs (30d)
5

Description

I always assumed the units in the playground are mm. When I use the default values for the Belt script, and export SVG, the overall size of the shape is in pixels. If I export the same values to a DXF file, the size is correct in mm.

I can update the SVG code to add mm after the size values in the first line of the SVG code. Should I assume that the SVG code is supposed to be exported in pixels?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the playground's SVG export path and compare its dimension handling with the DXF export, using the Belt script's default values as the reproduction case. Confirm the intended unit convention for SVG and document or test the behavior so exported dimensions match that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.