microsoft / microsoft/maker.js

Dogbones on chains

Open
#462 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
2k
Forks
302
Avg merge
21h 28m
Merged PRs (30d)
5

Description

I recently jumped back into an older ticket https://github.com/microsoft/maker.js/issues/336.

Some imported SVG paths behave very odd. While trying to figure out why it behaves like this, I took your dognone example from here: https://maker.js.org/docs/working-with-chains/#Chain%20dogbone and rotated the second rect by 15 degrees.

image

The left chain is perfect. But not the one on the right. ;-) Any idea, why that happens?

https://maker.js.org/playground/?script=https://gist.githubusercontent.com/3kmch/c1eb398d8bcf6af2dafefc0c04a5b735/raw/8dfdae2388e8e557db0fb05d091b3f20da66d369/dogbones%2520and%2520chains

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the older issue #336 and the dogbone example in the Working with Chains documentation, then reproduce the rotated-rectangle case in the linked Maker.js playground script. Compare the left and right chains and trace the behavior involved in imported SVG paths. Done means the rotated chain behaves correctly or the issue has a documented explanation and regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.