microsoft / microsoft/maker.js
Having a hard time expanding complex shapes
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 302
- Avg merge
- 21h 28m
- Merged PRs (30d)
- 5
Description
Making an outline on a complex shape (from a svg I imported into maker.js models) is very slow.
I tried simplifying the model, and converting to some keypoints and ConnectingTheDots, but it doesn't improve much, sometimes (probably due to the model) I get the following error:
index.js:6439 Uncaught TypeError: Cannot read property 'valueIds' of undefined
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named. Reproduce the slow outline expansion with the imported SVG or a similarly complex maker.js model, including the simplification and ConnectingTheDots attempts, then verify that expansion completes without the valueIds error and with acceptable performance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100