microsoft / microsoft/machnet

DPDK is linked dynamically, we want STATIC most probably.

Open
#44 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
162
Forks
33
PR merge metrics
No merged PRs in 30d

Description

Hi everyone,

Recent changes resulted in the dynamic linking of libraries.

Of course, a solution exists, but static linking is a better choice. It seems the package config module in CMake is not doing static linking properly, and I believe this is the culprit.

https://github.com/microsoft/machnet/blob/2a1bcd34ca29b6fccf0fdded4deda10c5357a18e/src/CMakeLists.txt#L23

Please have a look and let me know what you think.

Thanks,
Alireza

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/CMakeLists.txt at the linked package-config usage and inspect how the DPDK libraries are selected for linking. Determine why the recent configuration produces dynamic libraries and verify that the resulting build links them statically.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.