Packet->append does increase the data region, but the packet len value stays the same.
Open
@marinosi is already working on this.
Since Oct 11, 2023.
- Dominant language
- C++
- Stars
- 162
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
Once we allocate a packet, we usually append some free space to be able to fit our data in the packet.
The way we are doing this is by calling packet->alloc. This, however, does not change the packet length property.
So if we call packet->length() we do not observe the new length there. Check here as an example:
https://github.com/microsoft/machnet/blob/15a937d5856dcf84139bf3db81083a206dbdd07a/src/include/machnet_engine.h#L928
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.