microsoft / microsoft/lsif-node

Early exit from LSIF tooling

Open
#139 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
198
Forks
40
Avg merge
3d 7h
Merged PRs (30d)
1

Description

When I run the LSIF tooling against the vscode repo, I get this error and the job terminates earlier than expected:

Error: Can't upgrade symbol data visibility for W9Wyh/ULV38V/wW5YBD9bg== from 1 to 4
    at StandardSymbolData.changeVisibility (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:432:23)
    at IndirectExportWalker.changeVisibility (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:1079:24)
    at IndirectExportWalker.visitSymbol (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:1109:14)
    at IndirectExportWalker.walkSymbol (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:1044:30)
    at IndirectExportWalker.walkSymbol (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:1062:26)
    at IndirectExportWalker.walkType (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:1034:18)
    at IndirectExportWalker.walkType (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:1011:26)
    at IndirectExportWalker.walkType (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:980:26)
    at IndirectExportWalker.walk (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:949:18)
    at TSProject.computeIndirectExports (C:\repos\VSCloudKernel\src\RichCodeNav.LSIF\node_modules\lsif-tsc\lib\lsif.js:2503:23)

I am guessing it has something to do with a change in the repo itself, because if I go back several commits, for example to 9A4005FDA8A656F3863DA92902BBB48DAD73A769, the tool runs successfully across the entire repo.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure by running the LSIF tooling against the current vscode repository, then compare it with commit 9A4005FDA8A656F3863DA92902BBB48DAD73A769. Start at TSProject.computeIndirectExports and the IndirectExportWalker/StandardSymbolData stack frames in lsif-tsc; done means indexing completes without the visibility error across the repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.