Add MapMemory::unmap
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.7k
- Forks
- 144
- Avg merge
- 12h 21m
- Merged PRs (30d)
- 146
Description
// TODO: if the copy or protect step fails, the pages allocated by
// map_zero are leaked because the MapMemory trait has no unmap
// method, and no caller cleans up partially-mapped segments either.
// Add an `unmap` method to MapMemory and clean up the reserved
// region on failure in ElfParsedFile::load().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the MapMemory trait and ElfParsedFile::load(), then trace how map_zero, copy, and protect report failures. Done means MapMemory has an unmap operation and load releases the reserved region when copying or protecting fails; verify the existing project tests afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 64/100