microsoft / microsoft/libHttpClient
There should be a version of HCHttpCallRequestSetSSLValidation for web sockets
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 295
- Forks
- 144
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 2
Description
I am adding support for Web Sockets to our title, and have been testing my work with a very simple locally run echo server. Everything works fine when testing over http, but switching to https fails as I am just using a self signed certificate for local testing.
For making HTTP calls, I call HCHttpCallRequestSetSSLValidation to skip the ssl validation, but there is no equivilent for web sockets. I found HCWebSocketSetProxyDecryptsHttps, and using a debugger to skip the empty proxy check was able to get a connection open over https with the ssl check bypassed. This is not sustainable in the long term, as I can't expect other developers to stick a breakpoint in a random bit of code and set a random variable to true.
Please consider adding a new function along the lines of HCWebSocketSetSSLValidation, which when called disables the SSL validation step.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing HCHttpCallRequestSetSSLValidation and HCWebSocketSetProxyDecryptsHttps entry points to understand how SSL validation is controlled for HTTP and WebSocket connections. Add the corresponding WebSocket-facing API described in the issue, then verify that a local WebSocket echo server using a self-signed certificate can connect when validation is disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 54/100