microsoft / microsoft/language-server-protocol

Links from hover 0-based or 1-based?

Open
#473 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clarification hover
Dominant language
TypeScript
Stars
13k
Forks
1k
Avg merge
6d 1h
Merged PRs (30d)
10

Description

The LSP should define whether the links returned from hover are 0-based or 1-based. This has created inconsistencies in the java language server where when you click some like file:///foof/bar.java#188 from within VSCode you are brought to line 188 whereas with other editors you are brought to line 187.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names LSP hover links and behavior in the Java language server, VSCode, and other editors, but no files or tests. Start by reading the protocol’s hover-link definition and comparing the reported line handling; done means the indexing convention is explicitly defined and the inconsistency has a corresponding verification.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, typescript, vscode
Domain
api, developer-experience
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.