microsoft / microsoft/language-server-protocol

Redundancy in `workspace/diagnostic` partial result type

Open
#2,281 0 comments 0 reactions 1 assignee View on GitHub

@dbaeumer is already working on this.

Since Jun 24, 2026.

Dominant language
TypeScript
Stars
13k
Forks
1k
Avg merge
6d 1h
Merged PRs (30d)
10

Description

Problem

The 3.18 spec defines the partial result type for workspace/diagnostic as follows:

partial result: The first literal send need to be a WorkspaceDiagnosticReport followed by n WorkspaceDiagnosticReportPartialResult literals defined as follows:

Note that WorkspaceDiagnosticReport and WorkspaceDiagnosticReportPartialResult have the exact same object signature, i.e. they serialize to the exact same data. Thus this typing is redundant, likely inherited from how document diagnostic partial results are defined.

Expected behavior

It would make more sense if the spec defined the partial result as the following (for example):

partial result: WorkspaceDiagnosticReportPartialResult[] where WorkspaceDiagnosticReportPartialResult is defined as follows:

Alternatives

Alternatively, the spec can be kept as-is (albeit, with a bit of redundancy) but the metaModel should be changed in a manner similar to the one requested in #2274

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.