microsoft / microsoft/language-server-protocol
Clarify `FileOperationFilter` matching logic
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13k
- Forks
- 1k
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 10
Description
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#fileOperationFilter does not explain if all filters need to match for a file to match or if only one needs to match. VSCode's implementation of the an LSP client assumes that only one filter needs to match (which does makes sense to me). But, a clarification on the spec itself would be useful
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the FileOperationFilter section in the linked LSP 3.17 specification and compare it with the cited client/src/common/fileOperations.ts implementation. Clarify in the specification whether filters use any-match semantics, then verify that the wording directly resolves the ambiguity raised in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100