microsoft / microsoft/language-server-protocol

didSave without didOpen

Open
#2,110 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clarification
Dominant language
TypeScript
Stars
13k
Forks
1k
Avg merge
6d 1h
Merged PRs (30d)
10

Description

In #1220 it has been clarified, that didChange requires a client to take ownership with didOpen. However it was never answered, whether the same applies to didSave. Could this be clarified as well?

Also, if didSave can happen without didOpen how is it possible to obtain the TextDocumentItem to which the notification relates.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #1220 and the protocol definitions for didOpen and didSave. Compare their ownership and document-reference requirements, then clarify whether didSave is valid without didOpen and how its related TextDocumentItem is obtained. Done means the specification answers both questions unambiguously.

Written by the indexing model from the issue text.

Assessment

Domain
api, documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.