microsoft / microsoft/language-server-protocol

Recommend relationship between error ranges and selections for quickfixes

Open
#1,897 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clarification
Dominant language
TypeScript
Stars
13k
Forks
1k
Avg merge
6d 1h
Merged PRs (30d)
10

Description

Given an error range and a selection range, when should we show the error? There are some choices:

A: overlap and selection is multi-character

------- error
      ----------- selection

B: error contains selection and selection is multi-character

--------------error
      ------selection

C

      ------errror
   --------------selection    

D

       ------errror
                 ----------selection       

E: error overlaps with selection (inclusive) and selection is single-character

       ------errror
               ^ selection       

F: error overlaps with selection (inclusive) and selection is single-character

       ------errror
                 ^ selection       

It would be nice if languages were consistent, so at least a recommendation would be most welcome!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with issue #1897 and compare the proposed error and selection range cases A–F. Determine and document one consistent recommendation for when quickfixes should be shown, including single-character selections, so language implementations can follow the same rule.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.