microsoft / microsoft/language-server-protocol

DefinitionRequest Change

Open
#1,778 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request goto
Dominant language
TypeScript
Stars
13k
Forks
1k
Avg merge
6d 1h
Merged PRs (30d)
10

Description

Attach A selectionRange to definitionRequest as given the code

let x = 1
print(x)

if you select x from right to left the cursor position is at the end and if you select it from left to right the cursor position is at the start. when you try and figure out if x is used, this makes it inconsistent. if a selectionRange was provided the client could choose what to use.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the language server protocol definition for definitionRequest and compare its existing position and range conventions. Determine how a client-provided selectionRange should be specified, including the left-to-right and right-to-left example, and verify that the resulting protocol wording is unambiguous.

Written by the indexing model from the issue text.

Assessment

Domain
api, devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.