microsoft / microsoft/language-server-protocol

Proposal: publish diagnostics notification changes instead of all messages

Open
#1,392 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

diagnostics feature-request
Dominant language
TypeScript
Stars
13k
Forks
1k
Avg merge
6d 1h
Merged PRs (30d)
10

Description

I am working on optimizing Live Share's diagnostic messaging. I suggest that we add an option for the PublishDiagnostics Notification so that we can publish the changes between sets of diagnostic messages. For example, if we are removing one diagnostic message, instead of having to re-send every diagnostic message except the one that we are removing, we could instead send that one diagnostic message with a parameter indicating that it should be removed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the PublishDiagnostics Notification definition and how diagnostic message sets are represented in the protocol. Determine the required change semantics and parameter shape, then define completion as a clear protocol proposal that covers removing diagnostics without resending unchanged messages.

Written by the indexing model from the issue text.

Assessment

Domain
api, devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.