microsoft / microsoft/language-server-protocol

Allow clients to report their own name and version to server

Open
#1,299 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request new request
Dominant language
TypeScript
Stars
13k
Forks
1k
Avg merge
6d 1h
Merged PRs (30d)
10

Description

Currently there seems to be hard-coded behaviour which means that any client implementation will always report itself as vscode and version of VS Code itself (e.g. 1.57.0):

https://github.com/microsoft/vscode-languageserver-node/blob/dca3c1a04797aaaa7d48060cca38b16efdf4392f/client/src/common/client.ts#L3217-L3220

However it seems more relevant and helpful to be reporting the real client name (e.g. extension name or package name) and version.

Would you be open to a PR that allows clients to overwrite clientInfo?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the client.ts location linked in the issue, around lines 3217-3220, and trace how clientInfo is currently constructed and sent. Determine how client implementations could provide their own name and version; done means clients can report values other than the hard-coded VS Code identity.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.