microsoft / microsoft/language-server-protocol

Additional option for window/showTextDocument

Open
#1,140 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

document feature-request
Dominant language
TypeScript
Stars
13k
Forks
1k
Avg merge
6d 1h
Merged PRs (30d)
10

Description

We already have a very similar command that we send to the client to display a particular document:

https://github.com/scalameta/metals/blob/9e2a418b210518567fe51483167658466c9e256c/metals/src/main/scala/scala/meta/internal/metals/ClientCommands.scala#L108

we also added an additional boolean option otherWindow which we use to specify that the document should not be opened in the focused currently window/tab.

I wonder if it would make sense to add that property to window/showTextDocument

This is especially useful for us when navigating over a stacktrace, which makes it possible to quickly jump around different classes without the need to go back to the stacktrace.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the existing ClientCommands.scala command around line 108 with the window/showTextDocument protocol entry point. Determine how an otherWindow option would be specified and what client behavior it must guarantee; done means the proposal is defined clearly enough for affected clients to implement consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala, typescript
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.