microsoft / microsoft/lage

lage version 2.5.2+ broken for lerna and pnpm workspaces.

Open
#655 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
816
Forks
88
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
lage version 2.5.2 and above broken for lerna and pnpm workspaces.

lage - Version 2.5.2 - 19 Workers
[09:48:00] - error     Error: <path> is using pnpm which has not been converted to async yet

This is probably a regression from PR #626 which change to use async API from workspace-tools, but those API error out (source) because the async version of the API isn't implemented yet in pnpm.ts and lerna.ts

To Reproduce
Set up a repo using lerna workspace or pnpm workspace and use lage on it.

Expected behavior
It works.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect PR #626 and the workspace-tools async API referenced in the report, then compare the pnpm.ts and lerna.ts implementations. Reproduce the failure in a pnpm or lerna workspace; done means lage 2.5.2+ runs successfully for both workspace types without the async API error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.