[RFC]: WorkerRunner should keep a watch on memory growth
Open
@kenotron is already working on this.
Since Sep 19, 2022.
dev design
- Dominant language
- TypeScript
- Stars
- 816
- Forks
- 88
- PR merge metrics
- No merged PRs in 30d
Description
Overview
Now that we have a WorkerRunner capability, we need to ensure that we warn users of "monotonic memory growth" - this would be a sure sign that a memory leak is occurring. A simple "heap size" monitoring per start & end of the target run SHOULD suffice.
Goals & non-goals
Goals
- at the start and end of a worker run, we should record the heap size
- if we noticed that the heap size is growing at some slope above X, we should issue a warning to the user (at least at the end)
Non Goals
- this should not be a feature to amend the
--profilefeature
Test Plan
- We will leverage an E2E test + a dummy-leaky-worker implementation to help us always identify a memory leak during an execution
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.