microsoft / microsoft/lage

[RFC]: WorkerRunner should keep a watch on memory growth

Open
#365 0 comments 0 reactions 1 assignee View on GitHub

@kenotron is already working on this.

Since Sep 19, 2022.

dev design
Dominant language
TypeScript
Stars
816
Forks
88
PR merge metrics
No merged PRs in 30d

Description

Overview

Now that we have a WorkerRunner capability, we need to ensure that we warn users of "monotonic memory growth" - this would be a sure sign that a memory leak is occurring. A simple "heap size" monitoring per start & end of the target run SHOULD suffice.

Goals & non-goals

Goals
  1. at the start and end of a worker run, we should record the heap size
  2. if we noticed that the heap size is growing at some slope above X, we should issue a warning to the user (at least at the end)
Non Goals
  1. this should not be a feature to amend the --profile feature

Test Plan

  • We will leverage an E2E test + a dummy-leaky-worker implementation to help us always identify a memory leak during an execution

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.