microsoft / microsoft/lage

Bumping Lage from 0.31.0 to 0.32.0 broke our monorepo's pipeline

Open
#155 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
816
Forks
88
PR merge metrics
No merged PRs in 30d

Description

I am an engineer on FluentUI React Native https://github.com/microsoft/fluentui-react-native

We use page to handle our pipeline tasks, and specifically a "JS PR" CI Step. A brief overview...

We have a build-tools step that must be run before any other step. After that, we have the usual set of build,lint,test, etc. We also have a buildci step that runs all of our steps, and is meant to be used as a CI step to check our code.

Following a dependency bump from 0.31.0 to 0.32.0, two things happened:

  1. build-tools was no longer run first
  2. buildci consisted of 0 steps, so it did nothing and passed.

The combination of those meant our pipeline silently broke until we downgraded late. It's possible our config file was wrong, but we'd love more info to see if that's the case
Our config, for reference

module.exports = {
  npmClient: 'yarn',
  pipeline: {
    ['build-tools']: ['^build-tools'],
    build: ['build-tools', '^build'],
    buildci: ['build', 'test', 'depcheck', 'bundle'],
    bundle: ['build-tools', 'build'],
    clean: [],
    depcheck: ['build-tools'],
    lint: ['build-tools'],
    prettier: ['build-tools'],
    ['prettier-fix']: ['build-tools'],
    ['verify-api']: [],
    ['update-api']: [],
    test: ['build-tools', 'lint', 'build'],
  },
};

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the supplied module.exports pipeline configuration as the reproduction case and compare behavior between Lage 0.31.0 and 0.32.0. Check why build-tools is not first and why buildci contains no steps; done means the configured pipeline order and buildci execution work correctly without downgrading.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.